pure negative children filter in parent block join query #3899
+36
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-16247
Description
Null return / 0 return when searching through negative query in child filter.
!parent filters= is prone to pure negative query
This was a fix worked and developed in the hackathon at London on the 28/11/2025
Solution
Solution is to take out the query from the filter , parse it through makeQueryable() which checks if the query is negative or not, if the query is negative , we add " : " to the query and wrap it in a filter again to return the query.
Tests
Wrote a testPureNegativeQueryInChildFilters() test which child the "childFq" to a negative query and checked that we get the correct value back with the removed negative query
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.